Minix3 port to be merged?

OSS related discussion in general (i.e. not limited to Linux/Solaris/BSD)

Moderators: cesium, dev, kodachi, hannu

Minix3 port to be merged?

Postby rafael2k » Wed Nov 04, 2009 7:15 pm

Hello people,
Will the Minix port be merged?
OSS, Minix, I'm feeling a little bit nostalgic...
: )

http://www.minix3.org/software/oss-v4.1 ... sd.tar.bz2
rafael2k
New Member
 
Posts: 6
Joined: Sat Nov 17, 2007 3:02 pm

Re: Minix3 port to be merged?

Postby cesium » Thu Nov 05, 2009 1:46 am

Hi,

First, there's no need to post this twice. If you must ask the devs directly, use the oss-devel mailing list.

Second, I can't speak for the devs, but I suspect they'll have no objections in principle. I did a diff on the port, and noticed a few marginal issues:

A) The build system can be modified in a less intrusive manner (e.g. use OSflags in srcconf.c to set -DOSS_NO_LONG_LONG instead of editing the .config files).
B) speaking of long long, a typedef may be preferable to lots of #ifdefs (But perhaps better to ask the devs about this first).
[Edit: I'll leave reviewing the grc3 changes to someone more informed]
C) Why was ossdevlinks modified to call system("rm..") instead of unlink() calls?

[Edit: I also suggest breaking up any commit to discrete changes. e.g. C++->C comment changes, OSS_NO_LONG_LONG changes, minix-wrapper, etc.]
cesium
Developer
 
Posts: 902
Joined: Sun Aug 12, 2007 12:51 am


Return to General Discussion

Who is online

Users browsing this forum: No registered users and 0 guests

cron